Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • U umobj
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • staffstaff
  • umobj
  • Merge requests
  • !61

syncobj: check that all path components are not files when creating directories

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Liam Monahan requested to merge download-existing-filename into master May 12, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

When trying to download a file check if any of its directory fragments that would be recursively created exist as a file.

This fixes a bug where we only checked if the directory key was a file, but this will not catch cases like this:

downloading directory foo/bar/baz/

We needed to check if foo, foo/bar for foo/bar/baz are files in the
local filesystem.  We were only checking foo/bar/baz

Resolves #40 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: download-existing-filename