dependencies
EDIT: Updated patch to include README.md change
EDIT2: The tripple backpacks in the README.md patch causes markdown issues… reverting the patch here to the one just for setup.py, but emailing full patch to Liam
I think netaddr
is a dependency… Line 6 in validators.py I was getting ready to create a Homebrew formula, but they require a simple test. So I tried to create a script matching the one on the README.md and got the following error:
$ python test.py
Traceback (most recent call last):
File "test.py", line 1, in <module>
from qav.questions import Question
File "/usr/local/lib/python2.7/site-packages/qav/questions.py", line 1, in <module>
from qav.validators import Validator, CompactListValidator
File "/usr/local/lib/python2.7/site-packages/qav/validators.py", line 6, in <module>
from netaddr import IPAddress
ImportError: No module named netaddr
I then tried to fork qav
but gitlab won’t let me due to an error. I’ll send a ticket to staff@umiacs with the details… So in lieu of a merge/pull request, here is a patch which I think should resolve the issue, however I have no personal experience publishing to PYPI.
From 771d92f83a97eaa449b537873ebe079013ebfa8e Mon Sep 17 00:00:00 2001
From: zbeekman <zbeekman@gmail.com>
Date: Wed, 8 Jul 2015 17:20:11 -0400
Subject: [PATCH] Added missing `netaddr` dependency
---
setup.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/setup.py b/setup.py
index d105353..99fb05a 100644
--- a/setup.py
+++ b/setup.py
@@ -21,6 +21,9 @@
author='Derek Yarnell',
author_email='derek@umiacs.umd.edu',
packages=['qav'],
+ install_requires=[
+ 'netaddr',
+ ],
url='https://github.com/UMIACS/qav',
license='MIT',
description='Question Answer Validation',
--
2.4.1
Put that in a file, say qav.patch
and then git apply qav.patch
or git am --signoff qav.patch
to apply it and commit. After bumping the version number, and pushing to gitlab and github, I think you should be able to resubmit to PYPI, for this to take effect.