From ce31f79941b179e20b6bfe405ae0fbd1a7925398 Mon Sep 17 00:00:00 2001
From: Michael Ritter <shake@umiacs.umd.edu>
Date: Mon, 14 Nov 2016 12:31:14 -0500
Subject: [PATCH 1/6] Fix index of parameter value

---
 .../ace/monitor/reporting/SummaryGenerator.java   | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/ace-am/src/main/java/edu/umiacs/ace/monitor/reporting/SummaryGenerator.java b/ace-am/src/main/java/edu/umiacs/ace/monitor/reporting/SummaryGenerator.java
index 575c339..72ac788 100644
--- a/ace-am/src/main/java/edu/umiacs/ace/monitor/reporting/SummaryGenerator.java
+++ b/ace-am/src/main/java/edu/umiacs/ace/monitor/reporting/SummaryGenerator.java
@@ -31,12 +31,17 @@
 
 package edu.umiacs.ace.monitor.reporting;
 
-import edu.umiacs.ace.monitor.log.*;
-import edu.umiacs.ace.util.PersistUtil;
 import edu.umiacs.ace.monitor.core.Collection;
+import edu.umiacs.ace.monitor.log.LogEnum;
+import edu.umiacs.ace.util.PersistUtil;
 import edu.umiacs.sql.SQL;
 import edu.umiacs.util.Argument;
 import edu.umiacs.util.Strings;
+import org.apache.log4j.Logger;
+
+import javax.persistence.EntityManager;
+import javax.persistence.EntityTransaction;
+import javax.sql.DataSource;
 import java.sql.Connection;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
@@ -45,10 +50,6 @@ import java.sql.Timestamp;
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
-import javax.persistence.EntityManager;
-import javax.persistence.EntityTransaction;
-import javax.sql.DataSource;
-import org.apache.log4j.Logger;
 
 /**
  * Log summary generator, this will generate a report summarizing all log entries
@@ -168,7 +169,7 @@ public class SummaryGenerator extends ReportItemTypes {
                         + "MIN(logevent.ID), logevent.LOGTYPE, count(logevent.LOGTYPE)"
                         + "FROM logevent WHERE logevent.COLLECTION_ID = ? "
                         + "GROUP BY logevent.LOGTYPE");
-                ps.setLong(2, collection.getId());
+                ps.setLong(1, collection.getId());
             }
 
             // create entries for each result, for start date and session id
-- 
GitLab


From 2f2d3d82ef24677a465b73859397240b795b5211 Mon Sep 17 00:00:00 2001
From: Michael Ritter <shake@umiacs.umd.edu>
Date: Mon, 14 Nov 2016 12:31:23 -0500
Subject: [PATCH 2/6] Use correct logger

---
 .../src/main/java/edu/umiacs/ace/rest/SettingsManagement.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ace-am/src/main/java/edu/umiacs/ace/rest/SettingsManagement.java b/ace-am/src/main/java/edu/umiacs/ace/rest/SettingsManagement.java
index 3fcd0fa..bba44d3 100644
--- a/ace-am/src/main/java/edu/umiacs/ace/rest/SettingsManagement.java
+++ b/ace-am/src/main/java/edu/umiacs/ace/rest/SettingsManagement.java
@@ -4,10 +4,11 @@
  */
 package edu.umiacs.ace.rest;
 
-import com.sun.istack.logging.Logger;
 import edu.umiacs.ace.driver.irods.IrodsSetting;
 import edu.umiacs.ace.monitor.core.Collection;
 import edu.umiacs.ace.util.PersistUtil;
+import org.apache.log4j.Logger;
+
 import javax.persistence.EntityManager;
 import javax.persistence.EntityTransaction;
 import javax.persistence.NoResultException;
-- 
GitLab


From 16fb0803ed8e05fe1c9a351704024ce0c3d877b9 Mon Sep 17 00:00:00 2001
From: Michael Ritter <shake@umiacs.umd.edu>
Date: Mon, 14 Nov 2016 12:32:49 -0500
Subject: [PATCH 3/6] Code cleanup

---
 .../ace/monitor/core/MonitoredItemManager.java      | 13 +++++++------
 .../src/main/java/edu/umiacs/ace/util/KSFuture.java |  1 +
 .../edu/umiacs/ace/hashtree/HashTreeBuilder.java    |  4 ++--
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/ace-am/src/main/java/edu/umiacs/ace/monitor/core/MonitoredItemManager.java b/ace-am/src/main/java/edu/umiacs/ace/monitor/core/MonitoredItemManager.java
index 8368180..3570d32 100644
--- a/ace-am/src/main/java/edu/umiacs/ace/monitor/core/MonitoredItemManager.java
+++ b/ace-am/src/main/java/edu/umiacs/ace/monitor/core/MonitoredItemManager.java
@@ -34,6 +34,11 @@ package edu.umiacs.ace.monitor.core;
 import edu.umiacs.ace.monitor.log.LogEnum;
 import edu.umiacs.ace.monitor.log.LogEventManager;
 import edu.umiacs.ace.util.PersistUtil;
+import org.apache.log4j.Logger;
+
+import javax.persistence.EntityManager;
+import javax.persistence.EntityTransaction;
+import javax.persistence.Query;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.Date;
@@ -42,10 +47,6 @@ import java.util.List;
 import java.util.Set;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
-import javax.persistence.EntityManager;
-import javax.persistence.EntityTransaction;
-import javax.persistence.Query;
-import org.apache.log4j.Logger;
 
 /**
  *
@@ -58,13 +59,13 @@ public class MonitoredItemManager {
             MonitoredItemManager.class);
     EntityManager em;
     // TODO: This may leak...
-    private Set<String> existingParents = new HashSet<String>();
+    private Set<String> existingParents = new HashSet<>();
 
     public MonitoredItemManager( EntityManager em ) {
         this.em = em;
     }
 
-    public List<MonitoredItem> listItemsBefore( Collection c, Date d ) {
+    public Iterable<MonitoredItem> listItemsBefore( Collection c, Date d ) {
         lock.lock();
         try {
 
diff --git a/ace-am/src/main/java/edu/umiacs/ace/util/KSFuture.java b/ace-am/src/main/java/edu/umiacs/ace/util/KSFuture.java
index 5ad819d..c62abab 100644
--- a/ace-am/src/main/java/edu/umiacs/ace/util/KSFuture.java
+++ b/ace-am/src/main/java/edu/umiacs/ace/util/KSFuture.java
@@ -49,6 +49,7 @@ public class KSFuture<V extends Runnable> extends KnownFuture<Submittable<V>> {
         Submittable<V> result = getKnownResult();
         beforeExecute(result);
         super.run();
+        // TODO: Check exception and print if true?
         afterExecute(result);
     }
 
diff --git a/ace-common/src/main/java/edu/umiacs/ace/hashtree/HashTreeBuilder.java b/ace-common/src/main/java/edu/umiacs/ace/hashtree/HashTreeBuilder.java
index 1ad4a43..38f019b 100644
--- a/ace-common/src/main/java/edu/umiacs/ace/hashtree/HashTreeBuilder.java
+++ b/ace-common/src/main/java/edu/umiacs/ace/hashtree/HashTreeBuilder.java
@@ -254,7 +254,7 @@ public final class HashTreeBuilder {
         // Find out how many nodes are going to be in the parent level
         int parentNodeCount = size / order;
         List<HashTree.Node> parentLevel =
-                new ArrayList<HashTree.Node>(parentNodeCount);
+                new ArrayList<>(parentNodeCount);
 
         // Index for iterating through the nodes in this level
         int iterIndex = 0;
@@ -290,7 +290,7 @@ public final class HashTreeBuilder {
 
             // Construct the parent node
             List<HashTree.Node> childrenNodes =
-                    new ArrayList<HashTree.Node>(childrenNodeCount);
+                    new ArrayList<>(childrenNodeCount);
             HashTree.Node parentNode = new HashTree.Node();
 
             for ( int i = iterIndex, childIndex = 0;
-- 
GitLab


From 8022b48a281574a2cea3911bda48f1188d24c6c6 Mon Sep 17 00:00:00 2001
From: Michael Ritter <shake@umiacs.umd.edu>
Date: Fri, 11 Nov 2016 16:56:39 -0500
Subject: [PATCH 4/6] Endpoint for querying collections

---
 .../edu/umiacs/ace/rest/ListController.java   | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java b/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java
index ba9b11a..afd2e55 100644
--- a/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java
+++ b/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java
@@ -5,15 +5,21 @@ import edu.umiacs.ace.util.PersistUtil;
 
 import javax.persistence.EntityManager;
 import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+import javax.persistence.criteria.Root;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
 import javax.ws.rs.PathParam;
 import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
 import javax.ws.rs.core.MediaType;
 import java.util.ArrayList;
 import java.util.List;
 
 /**
+ * Get a listing of groups/collections in ACE
+ *
  * Created by shake on 10/22/14.
  */
 @Path("/")
@@ -75,4 +81,31 @@ public class ListController {
         return groupless;
     }
 
+    /**
+     * New API method to get all collections with query parameters
+     *
+     * @return
+     */
+    @GET
+    @Path("collections")
+    @Produces(MediaType.APPLICATION_JSON)
+    public List<Collection> getCollections(@QueryParam("group") String group,
+                                           @QueryParam("active") Boolean active,
+                                           @QueryParam("corrupt") Boolean corrupt) {
+        EntityManager entityManager = PersistUtil.getEntityManager();
+        CriteriaBuilder cb = entityManager.getCriteriaBuilder();
+        CriteriaQuery<Collection> cq = cb.createQuery(Collection.class);
+        Root<Collection> coll = cq.from(Collection.class);
+        cq.select(coll);
+        if (active != null && active) {
+            cq.where(cb.equal(coll.get("state"), 'A'));
+        }
+
+        if (corrupt != null && corrupt) {
+            cq.where(cb.equal(coll.get("state"), 'E'));
+        }
+
+        return entityManager.createQuery(cq).getResultList();
+    }
+
 }
-- 
GitLab


From b54cbf636e95dca15bd800735aed05b1ea90a772 Mon Sep 17 00:00:00 2001
From: Michael Ritter <shake@umiacs.umd.edu>
Date: Fri, 11 Nov 2016 17:00:49 -0500
Subject: [PATCH 5/6] Fields for debugging

---
 ace-am/src/main/resources/META-INF/persistence.xml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ace-am/src/main/resources/META-INF/persistence.xml b/ace-am/src/main/resources/META-INF/persistence.xml
index ff2ccf4..52e93a2 100644
--- a/ace-am/src/main/resources/META-INF/persistence.xml
+++ b/ace-am/src/main/resources/META-INF/persistence.xml
@@ -23,6 +23,9 @@
     <exclude-unlisted-classes>true</exclude-unlisted-classes>
     <properties>
       <!-- <property name="toplink.logging.level" value="FINE"/> -->
+      <!-- <property name="eclipselink.logging.file" value="/tmp/eclipselink.log"/> -->
+      <!-- <property name="eclipselink.logging.level" value="FINE"/> -->
+      <!-- <property name="eclipselink.logging.level.sql" value="FINE"/> -->
       <property name="eclipselink.session.customizer" value="edu.umiacs.ace.util.DataSourceSessionCustomizer"/>
       <!-- <property name="eclipselink.create-ddl-jdbc-file-name" value="create.sql"/>
       <property name="eclipselink.ddl-generation.output-mode" value="sql-script"/>
-- 
GitLab


From e3e76d59479714645d7f73e44608568dee1d2e6a Mon Sep 17 00:00:00 2001
From: Michael Ritter <shake@umiacs.umd.edu>
Date: Mon, 14 Nov 2016 15:44:08 -0500
Subject: [PATCH 6/6] API Method for getting monitoreditems

---
 .../edu/umiacs/ace/rest/ListController.java   |  39 ++++++-
 .../umiacs/ace/rest/MonitoredItemBean.java    | 107 ++++++++++++++++++
 2 files changed, 145 insertions(+), 1 deletion(-)
 create mode 100644 ace-am/src/main/java/edu/umiacs/ace/rest/MonitoredItemBean.java

diff --git a/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java b/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java
index afd2e55..5cfbf70 100644
--- a/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java
+++ b/ace-am/src/main/java/edu/umiacs/ace/rest/ListController.java
@@ -1,7 +1,9 @@
 package edu.umiacs.ace.rest;
 
 import edu.umiacs.ace.monitor.core.Collection;
+import edu.umiacs.ace.monitor.core.MonitoredItem;
 import edu.umiacs.ace.util.PersistUtil;
+import org.apache.log4j.Logger;
 
 import javax.persistence.EntityManager;
 import javax.persistence.Query;
@@ -24,6 +26,7 @@ import java.util.List;
  */
 @Path("/")
 public class ListController {
+    private static final Logger LOG = Logger.getLogger(ListController.class);
 
     /**
      * Get a list of all the groups registered in ACE
@@ -70,7 +73,7 @@ public class ListController {
         // Get all
         Query q = em.createNamedQuery("Collection.listAllCollections");
         List<Collection> results = q.getResultList();
-        List<Collection> groupless = new ArrayList<Collection>();
+        List<Collection> groupless = new ArrayList<>();
 
         // Filter if the group == null
         for (Collection result : results) {
@@ -108,4 +111,38 @@ public class ListController {
         return entityManager.createQuery(cq).getResultList();
     }
 
+    /**
+     * API for getting items in a collection. We can offer more query parameters (path, last seen, etc),
+     * but for now just query based on state
+     *
+     * @param id The id of the collection
+     * @param state The state of the monitored items
+     * @return a list of monitored items for the collection
+     */
+    @GET
+    @Path("collections/{id}/items")
+    @Produces(MediaType.APPLICATION_JSON)
+    public List<MonitoredItemBean> getCollectionItems(@PathParam("id") Long id,
+                                                      @QueryParam("state") String state) {
+        EntityManager entityManager = PersistUtil.getEntityManager();
+        Collection c = entityManager.find(Collection.class, id);
+
+        CriteriaBuilder cb = entityManager.getCriteriaBuilder();
+        CriteriaQuery<MonitoredItemBean> cq = cb.createQuery(MonitoredItemBean.class);
+        Root<MonitoredItem> mi = cq.from(MonitoredItem.class);
+
+        cq.select(cb.construct(MonitoredItemBean.class,
+                mi.get("id"), mi.get("path"),
+                mi.get("state"), mi.get("fileDigest"),
+                mi.get("size"), mi.get("lastSeen"),
+                mi.get("stateChange"), mi.get("lastVisited")));
+
+        cq.where(cb.equal(mi.get("parentCollection"), c));
+        if (state != null && !state.isEmpty()) {
+            cq.where(cb.equal(mi.get("state"), state));
+        }
+
+        return entityManager.createQuery(cq).getResultList();
+    }
+
 }
diff --git a/ace-am/src/main/java/edu/umiacs/ace/rest/MonitoredItemBean.java b/ace-am/src/main/java/edu/umiacs/ace/rest/MonitoredItemBean.java
new file mode 100644
index 0000000..ec94553
--- /dev/null
+++ b/ace-am/src/main/java/edu/umiacs/ace/rest/MonitoredItemBean.java
@@ -0,0 +1,107 @@
+package edu.umiacs.ace.rest;
+
+import java.util.Date;
+
+/**
+ * Bean for displaying certain MonitoredItem properties in our api
+ *
+ * Created by shake on 11/14/16.
+ */
+public class MonitoredItemBean {
+
+    private Long id;
+    private String path;
+    private String state;
+    private String fileDigest;
+    private Long size;
+    private Date lastSeen;
+    private Date stateChange;
+    private Date lastVisited;
+
+    public MonitoredItemBean() {
+    }
+
+    public MonitoredItemBean(Long id, String path, char state, String fileDigest, Long size , Date lastSeen, Date stateChange, Date lastVisited) {
+        this.id = id;
+        this.path = path;
+        this.state = String.valueOf(state);
+        this.fileDigest = fileDigest;
+        this.size = size;
+        this.lastSeen = lastSeen;
+        this.stateChange = stateChange;
+        this.lastVisited = lastVisited;
+    }
+
+
+    public Long getId() {
+        return id;
+    }
+
+    public MonitoredItemBean setId(Long id) {
+        this.id = id;
+        return this;
+    }
+
+    public String getPath() {
+        return path;
+    }
+
+    public MonitoredItemBean setPath(String path) {
+        this.path = path;
+        return this;
+    }
+
+    public String getState() {
+        return state;
+    }
+
+    public MonitoredItemBean setState(String state) {
+        this.state = state;
+        return this;
+    }
+
+    public String getFileDigest() {
+        return fileDigest;
+    }
+
+    public MonitoredItemBean setFileDigest(String fileDigest) {
+        this.fileDigest = fileDigest;
+        return this;
+    }
+
+    public Long getSize() {
+        return size;
+    }
+
+    public MonitoredItemBean setSize(Long size) {
+        this.size = size;
+        return this;
+    }
+
+    public Date getLastSeen() {
+        return lastSeen;
+    }
+
+    public MonitoredItemBean setLastSeen(Date lastSeen) {
+        this.lastSeen = lastSeen;
+        return this;
+    }
+
+    public Date getStateChange() {
+        return stateChange;
+    }
+
+    public MonitoredItemBean setStateChange(Date stateChange) {
+        this.stateChange = stateChange;
+        return this;
+    }
+
+    public Date getLastVisited() {
+        return lastVisited;
+    }
+
+    public MonitoredItemBean setLastVisited(Date lastVisited) {
+        this.lastVisited = lastVisited;
+        return this;
+    }
+}
-- 
GitLab